Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable yamllint for Helm Chart and GitHub Actions #2018

Merged
merged 4 commits into from
May 23, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,8 @@ on:
tags:
- "v[0-9]+.[0-9]+.[0-9]+*"
pull_request:
branches:
- "*"
schedule:
- cron: "0 4 * * *" # run every day at 4am UTC

Expand Down
2 changes: 2 additions & 0 deletions .github/workflows/lint.yml
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,8 @@ on:
branches:
- main
pull_request:
branches:
- "*"

defaults:
run:
Expand Down
6 changes: 3 additions & 3 deletions .github/workflows/nfr.yml
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,7 @@ jobs:

- name: Authenticate to Google Cloud
id: auth
uses: google-github-actions/auth@71fee32a0bb7e97b4d33d548e7d957010649d8fa # v2.1.3
uses: google-github-actions/auth@71fee32a0bb7e97b4d33d548e7d957010649d8fa # v2.1.3
with:
token_format: access_token
workload_identity_provider: ${{ secrets.GCP_WORKLOAD_IDENTITY }}
Expand Down Expand Up @@ -144,9 +144,9 @@ jobs:
working-directory: ./tests
run: |
if ${{ inputs.test_label != 'all' }}; then
sed -i '/^GINKGO_LABEL=/s/=.*/="${{ inputs.test_label }}"/' "scripts/vars.env" && make nfr-test;
sed -i '/^GINKGO_LABEL=/s/=.*/="${{ inputs.test_label }}"/' "scripts/vars.env" && make nfr-test;
else
make nfr-test;
make nfr-test;
fi

- name: Cleanup
Expand Down
3 changes: 1 addition & 2 deletions .yamllint.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -4,10 +4,9 @@ yaml-files:
- "*.yml"

ignore:
- charts/nginx-gateway-fabric
- charts/nginx-gateway-fabric/templates
- config/crd/bases/
- deploy/crds.yaml
- .github/workflows/

rules:
braces: enable
Expand Down
19 changes: 10 additions & 9 deletions charts/nginx-gateway-fabric/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,8 @@ nginx:
plus: false

## The configuration for the data plane that is contained in the NginxProxy resource.
config: {}
config:
{}
# disableHTTP2: false
# telemetry:
# exporter:
Expand Down Expand Up @@ -138,14 +139,14 @@ service:
## A list of ports to expose through the NGINX Gateway Fabric service. Update it to match the listener ports from
## your Gateway resource. Follows the conventional Kubernetes yaml syntax for service ports.
ports:
- port: 80
targetPort: 80
protocol: TCP
name: http
- port: 443
targetPort: 443
protocol: TCP
name: https
- port: 80
targetPort: 80
protocol: TCP
name: http
- port: 443
targetPort: 443
protocol: TCP
name: https

metrics:
## Enable exposing metrics in the Prometheus format.
Expand Down
Loading