-
Notifications
You must be signed in to change notification settings - Fork 110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix graceful recovery tests #2440
Merged
kate-osborn
merged 3 commits into
nginx:main
from
kate-osborn:fix/graceful-recovery-test
Aug 22, 2024
Merged
Fix graceful recovery tests #2440
kate-osborn
merged 3 commits into
nginx:main
from
kate-osborn:fix/graceful-recovery-test
Aug 22, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2440 +/- ##
=======================================
Coverage 88.84% 88.84%
=======================================
Files 100 100
Lines 7527 7527
Branches 50 50
=======================================
Hits 6687 6687
Misses 784 784
Partials 56 56 ☔ View full report in Codecov by Sentry. |
bddacea
to
f62bd42
Compare
f62bd42
to
22c88b9
Compare
sjberman
approved these changes
Aug 22, 2024
lucacome
approved these changes
Aug 22, 2024
bjee19
approved these changes
Aug 22, 2024
miledxz
added a commit
to miledxz/nginx-gateway-fabric
that referenced
this pull request
Jan 14, 2025
Problem: Graceful recovery tests were failing in the pipeline Solutions: - Increase timeout when testing for passing/failing traffic after a container or pod restart. The timeout was set to 20 seconds, with a polling interval of 500ms, but the per-request timeout was 10 seconds. This means we were only retrying the request twice when a request timed out because it couldn't connect. Increasing the overall timeout to 60 seconds increased the number of retries and eliminated the errors. - Remove the kubectl drain flag --delete-local-data since it no longer exists and replace it with --delete-emptydir-data.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix graceful recovery tests
Problem: Graceful recovery tests were failing in the pipeline
Solutions:
kubectl drain
flag--delete-local-data
since it no longer exists and replace it with--delete-emptydir-data.
See: Update deprecated kubectl flag delete-local-data in kubeadm docs kubernetes/website#29058.Fixes #2429
Testing:
Checklist
Before creating a PR, run through this checklist and mark each as complete.