-
Notifications
You must be signed in to change notification settings - Fork 110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable more parallel tests #2572
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2572 +/- ##
=======================================
Coverage 89.29% 89.29%
=======================================
Files 100 100
Lines 7633 7633
Branches 50 50
=======================================
Hits 6816 6816
Misses 761 761
Partials 56 56 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
I was wondering we could run into more data race conditions since some of these tests do use variables between tests.
We should be careful moving forward, what do you think ?
Yeah I think we should make the tests as much independent as possible so we can catch actual data race problems |
Proposed changes
More tests in parallel
Checklist
Before creating a PR, run through this checklist and mark each as complete.
Release notes
If this PR introduces a change that affects users and needs to be mentioned in the release notes,
please add a brief note that summarizes the change.