Skip to content

Collect UpstreamSettingsPolicyCount in telemetry #2922

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

kate-osborn
Copy link
Contributor

Proposed changes

Problem: Want to collect number of UpstreamSettingsPolicies in cluster.

Solution: Collect the count of UpstreamSettingsPolicies in cluster.

Testing: Unit tests and manually verified collection via debug logs

Closes #2370

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

Release notes

If this PR introduces a change that affects users and needs to be mentioned in the release notes,
please add a brief note that summarizes the change.

Collect UpstreamSettingsPolicy count for data telemetry

@kate-osborn kate-osborn requested review from a team as code owners December 17, 2024 17:21
@github-actions github-actions bot added documentation Improvements or additions to documentation enhancement New feature or request tests Pull requests that update tests labels Dec 17, 2024
@kate-osborn kate-osborn merged commit ac9c937 into nginx:feature/upstream-settings-policy Dec 19, 2024
37 checks passed
kate-osborn added a commit to kate-osborn/nginx-gateway-fabric that referenced this pull request Dec 20, 2024
Problem: Want to collect number of UpstreamSettingsPolicies in cluster.

Solution: Collect the count of UpstreamSettingsPolicies in cluster.
kate-osborn added a commit that referenced this pull request Dec 20, 2024
Problem: Want to collect number of UpstreamSettingsPolicies in cluster.

Solution: Collect the count of UpstreamSettingsPolicies in cluster.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request tests Pull requests that update tests
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants