CP/DP Split: write configuration to agent #2999
Merged
+5,341
−628
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
documentation
kate-osborn
reviewed
Jan 10, 2025
sjberman
force-pushed
the
chore/agent-nginx-config
branch
from
40cc29b to
10c6e3e
Compare
kate-osborn
requested changes
Jan 27, 2025
bjee19
reviewed
Jan 27, 2025
bjee19
reviewed
Jan 27, 2025
salonichf5
reviewed
Jan 28, 2025
kate-osborn
approved these changes
Jan 28, 2025
salonichf5
approved these changes
Jan 28, 2025
bjee19
approved these changes
Jan 28, 2025
kate-osborn
approved these changes
Jan 28, 2025
This commit adds functionality to send nginx configuration to the agent. It also adds support for the single nginx Deployment to be scaled, and send configuration to all replicas. This requires tracking all Subscriptions for a particular deployment, and receiving all responses from those replicas to determine the status to write to the Gateway.
sjberman
force-pushed
the
chore/agent-nginx-config
branch
from
79993d9 to
efd12b5
Compare
sjberman
merged commit 84b4019
into
nginx:change/control-data-plane-split
17 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds functionality to send nginx configuration to the agent. It also adds support for the single nginx Deployment to be scaled, and send configuration to all replicas. This requires tracking all Subscriptions for a particular deployment, and receiving all responses from those replicas to determine the status to write to the Gateway.
Testing: Created Gateway API resources and saw the configuration applied to the nginx deployment. Scaled nginx and saw those applied as well.
Closes #2842