-
Notifications
You must be signed in to change notification settings - Fork 142
Automate Operator certification #4288
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4288 +/- ##
==========================================
+ Coverage 86.05% 86.09% +0.04%
==========================================
Files 132 132
Lines 14342 14342
Branches 35 35
==========================================
+ Hits 12342 12348 +6
+ Misses 1794 1791 -3
+ Partials 206 203 -3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
0359c2c to
babe503
Compare
| cp -R ../../../operators/bundle/manifests v${{ inputs.operator-version }}/ | ||
| cp -R ../../../operators/bundle/metadata v${{ inputs.operator-version }}/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can the root of the directory be used? This relative path seems flimsy.
|
|
||
| If RBAC permissions in the Helm chart change, update [config/rbac/role.yaml](config/rbac/role.yaml) accordingly. The next time `make bundle` runs, these RBAC changes will be reflected in the bundle manifests. | ||
|
|
||
| #### Manual Items to Check |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If there are steps in here that we need to perform before releasing, we should link to it in the release process doc if we don't already.
| set -e | ||
|
|
||
| SCRIPT_DIR="$(cd "$(dirname "${BASH_SOURCE[0]}")" && pwd)" | ||
| OPERATOR_RBAC="$SCRIPT_DIR/../config/rbac/role.yaml" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this RBAC file be the exact same as what is in our helm chart? Can we just directly compare them, instead of this complex script of comparing each field?
Proposed changes
Problem: The operator certification is currently a manual process.
Solution:
Testing: TBD
TODO: Add required secrets to the repo
Closes #4273
Checklist
Before creating a PR, run through this checklist and mark each as complete.
Release notes
If this PR introduces a change that affects users and needs to be mentioned in the release notes,
please add a brief note that summarizes the change.