Revert "Review: Add default case to all select block"

This reverts commit 4ff0cc7.

Author: mrajagopal

pkg/jobs/common_job_list_test.go

@@ -53,10 +53,6 @@ func TestCommonJobList_SelectedJobsProduceFiles(t *testing.T) {
 			}
 		case <-ctx.Done():
 			t.Fatalf("job %s timed out", job.Name)
-
-		default:
-			// No result yet, which is unexpected since we set a timeout above
-			t.Fatalf("job %s did not return result", job.Name)
 		}
 	}
 }

pkg/jobs/ngx_job_list_test.go

@@ -73,9 +73,6 @@ func TestNGXJobList_ExecNginxT(t *testing.T) {
 		}
 	case <-time.After(time.Second):
 		t.Fatal("job execution timed out")
-
-	default:
-		t.Fatalf("job %s did not return result", job.Name)
 	}
 }
 

pkg/jobs/nic_job_list_test.go

@@ -69,9 +69,6 @@ func TestNICJobList_ExecJobs(t *testing.T) {
 			}
 		case <-time.After(time.Second):
 			t.Errorf("Job %s timed out", job.Name)
-
-		default:
-			t.Errorf("Job %s did not return result", job.Name)
 		}
 	}
 }
@@ -104,9 +101,6 @@ func TestNICJobList_CRDObjects(t *testing.T) {
 				}
 			case <-time.After(time.Second):
 				t.Errorf("CRD job timed out")
-
-			default:
-				t.Errorf("CRD job %s did not return result", job.Name)
 			}
 		}
 	}
@@ -186,9 +180,6 @@ func TestNICJobList_CRDObjects_QueryFailure(t *testing.T) {
 
 	case <-ctx.Done():
 		t.Fatal("CRD job timed out")
-
-	default:
-		t.Fatalf("CRD job %s did not return result", crdJob.Name)
 	}
 }
 
@@ -497,9 +488,6 @@ func TestNICJobList_CommandExecutionFailure(t *testing.T) {
 
 			case <-ctx.Done():
 				t.Fatalf("Job %s timed out", tt.jobName)
-
-			default:
-				t.Fatalf("Job %s did not return result", tt.jobName)
 			}
 		})
 	}
@@ -566,8 +554,5 @@ func TestNICJobList_CollectProductPlatformInfo_JSONMarshalFailure(t *testing.T)
 
 	case <-ctx.Done():
 		t.Fatal("Job timed out")
-
-	default:
-		t.Fatalf("Job %s did not return result", job.Name)
 	}
 }

pkg/jobs/nim_job_list_test.go

@@ -103,9 +103,6 @@ func TestNIMJobList_ExecJobs(t *testing.T) {
 			}
 		case <-time.After(2 * time.Second):
 			t.Errorf("Job %s timed out", job.Name)
-
-		default:
-			t.Errorf("Job %s did not return result", job.Name)
 		}
 	}
 }
@@ -138,9 +135,6 @@ func TestNIMJobList_ExcludeFlags(t *testing.T) {
 				}
 			case <-time.After(time.Second):
 				t.Fatal("Job exec-clickhouse-data timed out")
-
-			default:
-				t.Fatalf("Job %s did not return result", job.Name)
 			}
 		}
 	}
@@ -158,9 +152,6 @@ func TestNIMJobList_ExcludeFlags(t *testing.T) {
 				}
 			case <-time.After(time.Second):
 				t.Fatal("Job exec-dqlite-dump timed out")
-
-			default:
-				t.Fatalf("Job %s did not return result", job.Name)
 			}
 		}
 	}