Byte-oriented methods for ngx_str_t
#91
Merged
+85
−12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xeioex
approved these changes
Oct 4, 2024
| /// # Safety | ||
| /// | ||
| /// The caller must provide a valid pointer to a memory pool. | ||
| pub unsafe fn from_bytes(pool: *mut ngx_pool_t, src: &[u8]) -> Option<Self> { |
There was a problem hiding this comment.
from_string() and from_str(), both return Self, not Option<Self>, shouldn't we change them as well?
There was a problem hiding this comment.
Not sure if it's worth fixing the str conversion functions. I planned to remove these or at least mark as deprecated.
Use unaligned allocations for strings.
A zero-length `ngx_str_t` is still valid, but the data pointer is not guaranteed to be valid or initialized in that case.
There's no guarantee we'll be working with a valid UTF-8 data.
bavshin-f5
force-pushed
the
byte-strings
branch
from
e9c0afb to
46e01bd
Compare
`size_t` is transformed to `usize` by default since bindgen 0.61. As we require much newer version of bindgen, the explicit casts are no longer necessary.
bavshin-f5
force-pushed
the
byte-strings
branch
from
46e01bd to
cb7e21d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ngx_str_tlikely does not contain UTF-8, so converting it from/to UTF-8 strings is expensive and useless.from_bytes()andas_bytes()should be a more appropriate interface.At some point in the future I intend to drop the
String/&strconversion methods, as these aren't safe.