Skip to content

Conversation

bavshin-f5
Copy link
Member

Non-functional change: reshuffle imports and ensure that the crate types don't leak from the exported macros.

All the types in `std::os::raw` are aliases to the `ffi` and it's
recommended to use 'std::ffi'[1].

[1]: https://doc.rust-lang.org/stable/std/os/raw/index.html
Unmerge a few excessively complex import statements.

The option itself is unstable, so it is commented in rustfmt.toml.

[1]: https://rust-lang.github.io/rustfmt/?version=master&search=#group_imports
Copy link
Contributor

@xeioex xeioex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All 3 patches look good to me.

@bavshin-f5 bavshin-f5 merged commit 969c870 into nginx:master Oct 25, 2024
7 checks passed
@bavshin-f5 bavshin-f5 deleted the formatting branch October 25, 2024 01:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants