New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HTTP: simplifed r.subrequest() code. #752

Merged

xeioex merged 1 commit into nginx:master from xeioex:git_rid_of_promise_callbacks

Jul 2, 2024

+71 −175

Contributor

xeioex commented Jun 29, 2024

Moving promise callbacks from ctx->promise_callbacks to the arguments of ngx_js_event_t.

Checklist

Before creating a PR, run through this checklist and mark each as complete:

I have read the CONTRIBUTING document
If applicable, I have added tests that prove my fix is effective or that my feature works
If applicable, I have checked that any relevant tests pass after adding my changes


          HTTP: simplifed r.subrequest() code.

90c7d6b

Moving promise callbacks from ctx->promise_callbacks to
the arguments of ngx_js_event_t.

xeioex requested a review from VadimZhestikov

June 29, 2024 05:11

VadimZhestikov approved these changes

View reviewed changes

xeioex merged commit 7dda4b2 into nginx:master

1 check passed

xeioex deleted the git_rid_of_promise_callbacks branch

July 2, 2024 02:36

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet