Fix Buffer.prototype.indexOf() and friends. #796
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, when `from` argument was provided heap-buffer-overflow might happen due to lack of boundary check. `to = njs_min(to, length)` statement was also removed because it has no effect, `to` is equal to `length` here. The issue was introduced in 5d15a8d (0.8.5). This closes nginx#794 issue on Github.
Previous incorrect fix was introduced in 5d15a8d (0.8.5).
With empty buffers in both the self and search cases.
xeioex
force-pushed
the
fix_buffer_indexOf
branch
from
bfafa6e
to
b4b40a3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.