Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing flaky ASAN CI build. #800

Merged
merged 2 commits into from
Oct 17, 2024
Merged

Conversation

xeioex
Copy link
Contributor

@xeioex xeioex commented Oct 15, 2024

No description provided.

Previously, when an exception was thrown, the exception got 'stack'
property attached which contained the backtrace information about where
the exception happened. This could be a heavy operation and it was not
always needed.

To optimize it, the process is split into 2 phases. The first phase
collects all the necessary info about the current stack. The second
phase, where the stack symbolization happens, occurs only when this
property is referenced.
Copy link
Contributor

@VadimZhestikov VadimZhestikov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Both commits looks good. "Lazy stack symbolization" nice catch.

@xeioex xeioex merged commit eda6fa7 into nginx:master Oct 17, 2024
1 check passed
@xeioex xeioex deleted the fix_flacky_asan_tests branch October 17, 2024 05:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants