-
Notifications
You must be signed in to change notification settings - Fork 332
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix build with wasmtime 27.0.0 #1493
Conversation
Does that still work with e.g. wasmtime 24? |
Ah, it looks like CI tells us it does not: https://github.com/nginx/unit/actions/runs/11979528350/job/33401907630?pr=1493 |
7232240
to
8735156
Compare
Thanks for the notice, I've just updated the patch. |
I guess we also want write perms to match current behaviour... |
8735156
to
d89eed2
Compare
Updated. |
Wasmtime 27.0.0 adjusted the C API to start flowing through the directory and file permission bits of the underlying rust wasi_config_preopen_dir() implementation. The directory permissions control whether a directory is read-only or whether you can create/modify files within. You always need at least WASMTIME_WASI_DIR_PERMS_READ. The file permissions control whether you can read or read/write files. WASMTIME_WASI_FILE_PERMS_WRITE seems to imply WASMTIME_WASI_FILE_PERMS_READ (but we add both just to make it clear what we want) [ Permissions tweak and commit message - Andrew ] Signed-off-by: Andrew Clayton <a.clayton@nginx.com>
d89eed2
to
6cc4d70
Compare
|
Merged. Thanks Sergey! |
No description provided.