Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check mode false #485

Merged
merged 2 commits into from
Oct 4, 2024
Merged

Check mode false #485

merged 2 commits into from
Oct 4, 2024

Conversation

tugytur
Copy link
Contributor

@tugytur tugytur commented Oct 2, 2024

Proposed changes

TASK [nginx_config : Verify that you are using a supported Jinja2 version on your Ansible host] ********************************************************************************
fatal: [scar2 -> localhost]: FAILED! => {"msg": "Unexpected templating type error occurred on (Jinja2 {{ jinja2_version['stdout'] | regex_search('jinja version = ([\\\\d.]+)', '\\\\1') | first }} is supported.): 'NoneType' object is not iterable. 'NoneType' object is not iterable"}

Ansible check mode was failing to due the empty jinja2_version variable. Added check_mode: false to make it pass

Checklist

Before creating a PR, run through this checklist and mark each as complete:

@tugytur tugytur requested a review from alessfg as a code owner October 2, 2024 17:51
Copy link

github-actions bot commented Oct 2, 2024

✅ All required contributors have signed the F5 CLA for this PR. Thank you!
Posted by the CLA Assistant Lite bot.

@tugytur
Copy link
Contributor Author

tugytur commented Oct 2, 2024

I have hereby read the F5 CLA and agree to its terms

@alessfg alessfg added the bug Something isn't working label Oct 4, 2024
@alessfg alessfg added this to the 0.7.2 milestone Oct 4, 2024
@alessfg
Copy link
Collaborator

alessfg commented Oct 4, 2024

Thanks for catching this and for the PR!

@alessfg alessfg merged commit 34ab70a into nginxinc:main Oct 4, 2024
12 checks passed
@alessfg alessfg removed their request for review October 4, 2024 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Development

Successfully merging this pull request may close these issues.

2 participants