Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: stability and bug fixes #138

Merged
merged 41 commits into from
May 5, 2022
Merged

fix: stability and bug fixes #138

merged 41 commits into from
May 5, 2022

Conversation

qdzlug
Copy link
Contributor

@qdzlug qdzlug commented May 3, 2022

Proposed changes

There are a number of small changes included in this PR.

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have written my commit messages in the Conventional Commits format.
  • I have read the CONTRIBUTING doc
  • I have added tests (when possible) that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto master
  • I will ensure my PR is targeting the master branch and pulling from my branch from my own fork

Copy link
Contributor

@4141done 4141done left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 🐳 👍
This all looks good to me. I had a few questions and nonblocking comments. You may want to ask a better unix person than me about the password generation command but I was able to grok it mostly.

docs/getting_started.md Show resolved Hide resolved
bin/start_aws.sh Outdated Show resolved Hide resolved
curl -Lo minikube https://storage.googleapis.com/minikube/releases/latest/minikube-linux-amd64 && chmod +x minikube
mkdir -p /usr/local/bin/
install minikube /usr/local/bin/
minikube start --vm-driver=podman
minikube start --vm-driver=none
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Question:
What is the reason that we no longer use podman with minikube?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You cannot run minikube as root w/ podman; the only option is with no driver or one of the non-docker drivers.

kubernetes/minikube#8257

A lot is going on there, and since this is a ephemeral VM that we're running, I went for the easiest way.

extras/jenkins/Minikube/Jenkinsfile Show resolved Hide resolved
Copy link
Contributor

@4141done 4141done left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 🐳 👍
Looks good to me. Only change suggestion is the removal of a comment but that's up to you.

Comment on lines +247 to +248
# TODO: Figure out a way to not hardocde the kubectl version
# TODO: Should not always download if the versions match; need a version check
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Likely out of scope for this PR, but you could consider having the project use asdf internally. Looks like there is a plugin for kubectl. It may not want to be something we foist on users, but it would let you potentially manage a lot of things with a .tool-versions file that contains a set of dependencies like:

kubctl 1.23.6
python 3.9.10
awscli x.x.x

Then running asdf install would install all of them at the correct versions automatically.

Full list of available plugins
We used this strategy extensively at pagerduty to keep build tooling in line with our dev tooling in CI.

bin/setup_venv.sh Show resolved Hide resolved
bin/setup_venv.sh Show resolved Hide resolved
bin/start_aws.sh Show resolved Hide resolved
bin/start_aws.sh Show resolved Hide resolved
config/pulumi/Pulumi.stackname.yaml.example Show resolved Hide resolved
config/pulumi/Pulumi.stackname.yaml.example Show resolved Hide resolved
@qdzlug qdzlug merged commit c33ed4e into nginxinc:master May 5, 2022
@qdzlug qdzlug deleted the jaymistake02 branch May 5, 2022 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: startup scripts hang on "Checking for required secrets"
2 participants