-
Notifications
You must be signed in to change notification settings - Fork 100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: stability and bug fixes #138
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 🐳 👍
This all looks good to me. I had a few questions and nonblocking comments. You may want to ask a better unix person than me about the password generation command but I was able to grok it mostly.
curl -Lo minikube https://storage.googleapis.com/minikube/releases/latest/minikube-linux-amd64 && chmod +x minikube | ||
mkdir -p /usr/local/bin/ | ||
install minikube /usr/local/bin/ | ||
minikube start --vm-driver=podman | ||
minikube start --vm-driver=none |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Question:
What is the reason that we no longer use podman with minikube?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You cannot run minikube as root w/ podman; the only option is with no driver or one of the non-docker drivers.
A lot is going on there, and since this is a ephemeral VM that we're running, I went for the easiest way.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 🐳 👍
Looks good to me. Only change suggestion is the removal of a comment but that's up to you.
# TODO: Figure out a way to not hardocde the kubectl version | ||
# TODO: Should not always download if the versions match; need a version check |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Likely out of scope for this PR, but you could consider having the project use asdf internally. Looks like there is a plugin for kubectl. It may not want to be something we foist on users, but it would let you potentially manage a lot of things with a .tool-versions
file that contains a set of dependencies like:
kubctl 1.23.6
python 3.9.10
awscli x.x.x
Then running asdf install
would install all of them at the correct versions automatically.
Full list of available plugins
We used this strategy extensively at pagerduty to keep build tooling in line with our dev tooling in CI.
Proposed changes
There are a number of small changes included in this PR.
Checklist
Before creating a PR, run through this checklist and mark each as complete.