Enable report-ingress-status by default

Also add get permissions on ingress resources, needed when the status updater is retrying a status update.
nginxinc · Aug 16, 2018 · 46500c1 · 46500c1
1 parent c1e723a
commit 46500c1
Show file tree

Hide file tree

Showing 4 changed files with 4 additions and 3 deletions.
diff --git a/helm-chart/README.md b/helm-chart/README.md
@@ -81,7 +81,7 @@ Parameter | Description | Default
 `controller.useIngressClassOnly` | Ignore Ingress resources without the `"kubernetes.io/ingress.class"` annotation. | false
 `controller.watchNamespace` | Namespace to watch for Ingress resources. By default the Ingress controller watches all namespaces. | ""
 `controller.healthStatus` | Add a location "/nginx-health" to the default server. The location responds with the 200 status code for any request. Useful for external health-checking of the Ingress controller. | false
-`controller.reportIngressStatus.enable` | Update the address field in the status of Ingresses resources with an external address of the Ingress controller. You must also specify the source of the external address either through an external service via `controller.reportIngressStatus.externalService` or the `external-status-address` entry in the ConfigMap via `controller.config.entries`. **Note:** `controller.config.entries.external-status-address` takes precedence if both are set. | false
+`controller.reportIngressStatus.enable` | Update the address field in the status of Ingresses resources with an external address of the Ingress controller. You must also specify the source of the external address either through an external service via `controller.reportIngressStatus.externalService` or the `external-status-address` entry in the ConfigMap via `controller.config.entries`. **Note:** `controller.config.entries.external-status-address` takes precedence if both are set. | true
 `controller.reportIngressStatus.externalService` | Specifies the name of the service with the type LoadBalancer through which the Ingress controller is exposed externally. The external address of the service is used when reporting the status of Ingress resources. `controller.reportIngressStatus.enable` must be set to `true`. | nginx-ingress
 `controller.reportIngressStatus.enableLeaderElection` | Enable Leader election to avoid multiple replicas of the controller reporting the status of Ingress resources. `controller.reportIngressStatus.enable` must be set to `true`. | true
 `rbac.create` | Configures RBAC. | true

diff --git a/helm-chart/templates/rbac.yaml b/helm-chart/templates/rbac.yaml
@@ -54,6 +54,7 @@ rules:
   resources:
   - ingresses
   verbs:
+  - get
   - list
   - watch
 {{- if .Values.controller.reportIngressStatus.enable }}

diff --git a/helm-chart/values-plus.yaml b/helm-chart/values-plus.yaml
@@ -29,7 +29,7 @@ controller:
     annotations: {}
   serviceAccountName: nginx-ingress
   reportIngressStatus:
-    enable: false
+    enable: true
     externalService: nginx-ingress
     enableLeaderElection: true
 rbac:

diff --git a/helm-chart/values.yaml b/helm-chart/values.yaml
@@ -29,7 +29,7 @@ controller:
     annotations: {}
   serviceAccountName: nginx-ingress
   reportIngressStatus:
-    enable: false
+    enable: true
     externalService: nginx-ingress
     enableLeaderElection: true
 rbac: