Add support for custom annotations in configmaps #1003
Merged
+16
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rulox
requested review from
pleshakov,
Dean-Coakley,
Rulox and
lucacome
and removed request for
pleshakov
|
Thanks @RubyLangdon we'll have a look and get back to you soon. |
Dean-Coakley
approved these changes
Jun 29, 2020
pleshakov
reviewed
Jun 29, 2020
deployments/helm-chart/templates/controller-leader-election-configmap.yaml
Show resolved
Hide resolved
Co-authored-by: Dean Coakley <dean.s.coakley@gmail.com>
Rulox
approved these changes
Jul 1, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
This allows annotations to be added to the configmaps in the helm chart.
One case where this is useful is when Spinnaker is used for deploying the chart.
Annotations are needed to control Spinnaker's behaviour when it deploys configmaps. For example, the annotation
strategy.spinnaker.io/versionedcontrols Spinnaker's versioning behaviour.Checklist
Before creating a PR, run through this checklist and mark each as complete.