Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add prometheus worker process metrics #1076

Merged
merged 2 commits into from
Jul 29, 2020
Merged

Add prometheus worker process metrics #1076

merged 2 commits into from
Jul 29, 2020

Conversation

LorcanMcVeigh
Copy link
Contributor

@LorcanMcVeigh LorcanMcVeigh commented Jul 28, 2020 •
edited
Loading

Proposed changes

Reports metrics of the number of NGINX worker processes in the current generation and the old generation ( the ones currently shutting down )

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto master
  • I will ensure my PR is targeting the master branch and pulling from my branch from my own fork

@LorcanMcVeigh LorcanMcVeigh self-assigned this Jul 28, 2020
Dean-Coakley
Dean-Coakley approved these changes Jul 28, 2020
View reviewed changes
Copy link
Contributor

@Dean-Coakley Dean-Coakley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

lucacome
lucacome approved these changes Jul 28, 2020
View reviewed changes
Copy link
Member

@lucacome lucacome left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just a small typo.

docs-web/logging-and-monitoring/prometheus.md Outdated Show resolved Hide resolved
@LorcanMcVeigh @lucacome
Update docs-web
723f433 
Co-authored-by: Luca Comellini <luca.com@gmail.com>
@LorcanMcVeigh LorcanMcVeigh merged commit 0e34d4b into master Jul 29, 2020
@LorcanMcVeigh LorcanMcVeigh deleted the support-process-metrics branch July 29, 2020 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lucacome lucacome lucacome approved these changes

@Dean-Coakley Dean-Coakley Dean-Coakley approved these changes

@pleshakov pleshakov Awaiting requested review from pleshakov

@Rulox Rulox Awaiting requested review from Rulox

Assignees

@LorcanMcVeigh LorcanMcVeigh

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@LorcanMcVeigh @lucacome @Dean-Coakley