Support pathType field in the Ingress resource #1080
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Should we change all the other examples in the docs that have |
lucacome
approved these changes
Jul 30, 2020
pleshakov
suggested changes
Jul 31, 2020
docs-web/configuration/ingress-resources/basic-configuration.md
Outdated
Show resolved
Hide resolved
pleshakov
suggested changes
Aug 5, 2020
There was a problem hiding this comment.
@LorcanMcVeigh please see comments/suggestion for the new code
docs-web/configuration/ingress-resources/basic-configuration.md
Outdated
Show resolved
Hide resolved
docs-web/configuration/ingress-resources/basic-configuration.md
Outdated
Show resolved
Hide resolved
docs-web/configuration/ingress-resources/basic-configuration.md
Outdated
Show resolved
Hide resolved
docs-web/configuration/ingress-resources/basic-configuration.md
Outdated
Show resolved
Hide resolved
pleshakov
suggested changes
Aug 5, 2020
| { | ||
| pathType: v1beta1.PathType(""), | ||
| path: "/path/to/resource", | ||
| expected: "/path/to/resource", |
There was a problem hiding this comment.
Could you add a case when pathType is nil ? this case is possible
Dean-Coakley
approved these changes
Aug 7, 2020
Dean-Coakley
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Implement v1 k8s 1.18 ingress changes
Checklist
Before creating a PR, run through this checklist and mark each as complete.