-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add IngressMTLS policy support #1166
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Just docs comments.
Co-authored-by: Dean Coakley <dean.s.coakley@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@lucacome
Please see my comments and suggestions. Mostly docs.
@lucacome - path: /coffee
action:
proxy:
upstream: coffee
requestHeaders:
set:
- name: s-dn
value: ${ssl_client_s_dn} I will add some documentation how to do that (and how to pass JWT claims/JOSE headers of JWT policy) as part of the doc update for this feature #1158 |
Co-authored-by: Michael Pleshakov <pleshakov@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@lucacome the changes look good! I noticed a small problem. Could you fix before merging?
Proposed changes
Add IngressMTLS policy support
Checklist
Before creating a PR, run through this checklist and mark each as complete.