Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add IngressMTLS policy support #1166

Merged
merged 5 commits into from
Oct 1, 2020
Merged

Add IngressMTLS policy support #1166

merged 5 commits into from
Oct 1, 2020

Conversation

lucacome
Copy link
Member

Proposed changes

Add IngressMTLS policy support

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto master
  • I will ensure my PR is targeting the master branch and pulling from my branch from my own fork

Copy link
Contributor

@Dean-Coakley Dean-Coakley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Just docs comments.

docs-web/configuration/policy-resource.md Outdated Show resolved Hide resolved
docs-web/configuration/policy-resource.md Outdated Show resolved Hide resolved
examples-of-custom-resources/ingress-mtls/README.md Outdated Show resolved Hide resolved
examples-of-custom-resources/ingress-mtls/README.md Outdated Show resolved Hide resolved
internal/configs/configurator.go Show resolved Hide resolved
Co-authored-by: Dean Coakley <dean.s.coakley@gmail.com>
Copy link
Contributor

@pleshakov pleshakov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lucacome
Please see my comments and suggestions. Mostly docs.

internal/configs/virtualserver.go Outdated Show resolved Hide resolved
examples-of-custom-resources/ingress-mtls/README.md Outdated Show resolved Hide resolved
deployments/helm-chart/crds/policy.yaml Outdated Show resolved Hide resolved
docs-web/configuration/policy-resource.md Outdated Show resolved Hide resolved
docs-web/configuration/policy-resource.md Outdated Show resolved Hide resolved
docs-web/configuration/policy-resource.md Outdated Show resolved Hide resolved
docs-web/configuration/policy-resource.md Outdated Show resolved Hide resolved
docs-web/configuration/policy-resource.md Show resolved Hide resolved
docs-web/configuration/policy-resource.md Outdated Show resolved Hide resolved
@pleshakov
Copy link
Contributor

@lucacome
We also need to capture how to propagate client cert info to the backend. Something like below:

  - path: /coffee
    action:
      proxy:
        upstream: coffee
        requestHeaders:
          set:
          - name: s-dn
            value: ${ssl_client_s_dn}

I will add some documentation how to do that (and how to pass JWT claims/JOSE headers of JWT policy) as part of the doc update for this feature #1158

lucacome and others added 2 commits September 30, 2020 13:44
Co-authored-by: Michael Pleshakov <pleshakov@users.noreply.github.com>
Copy link
Contributor

@pleshakov pleshakov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lucacome the changes look good! I noticed a small problem. Could you fix before merging?

internal/configs/virtualserver.go Outdated Show resolved Hide resolved
@lucacome lucacome merged commit a95499f into master Oct 1, 2020
@lucacome lucacome deleted the ingress-mtls branch October 1, 2020 05:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants