Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for EgressMTLS #1180

Merged
merged 9 commits into from
Oct 9, 2020
Merged

Add support for EgressMTLS #1180

merged 9 commits into from
Oct 9, 2020

Conversation

lucacome
Copy link
Member

@lucacome lucacome commented Oct 8, 2020

Adding support for Egress MTLS. Docs will come in another PR.

Copy link
Contributor

@LorcanMcVeigh LorcanMcVeigh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks Good, just spotted this because of the linter

pkg/apis/configuration/validation/policy.go Outdated Show resolved Hide resolved
Copy link
Contributor

@pleshakov pleshakov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @lucacome

Please see my comments and suggestions.

pkg/apis/configuration/v1alpha1/types.go Outdated Show resolved Hide resolved
pkg/apis/configuration/validation/policy.go Outdated Show resolved Hide resolved
pkg/apis/configuration/validation/policy.go Show resolved Hide resolved
pkg/apis/configuration/validation/policy.go Show resolved Hide resolved
examples-of-custom-resources/egress-mtls/README.md Outdated Show resolved Hide resolved
examples-of-custom-resources/egress-mtls/README.md Outdated Show resolved Hide resolved
examples-of-custom-resources/egress-mtls/README.md Outdated Show resolved Hide resolved
examples-of-custom-resources/egress-mtls/README.md Outdated Show resolved Hide resolved
lucacome and others added 2 commits October 8, 2020 13:11
Co-authored-by: Michael Pleshakov <pleshakov@users.noreply.github.com>
Co-authored-by: Lorcan McVeigh <lorcan.mcveigh@gmail.com>
internal/k8s/controller_test.go Outdated Show resolved Hide resolved
internal/configs/virtualserver.go Outdated Show resolved Hide resolved
internal/configs/virtualserver.go Show resolved Hide resolved
examples-of-custom-resources/egress-mtls/README.md Outdated Show resolved Hide resolved
internal/configs/virtualserver.go Outdated Show resolved Hide resolved
internal/k8s/controller.go Outdated Show resolved Hide resolved
pkg/apis/configuration/v1alpha1/types.go Outdated Show resolved Hide resolved
lucacome and others added 2 commits October 9, 2020 12:23
Co-authored-by: Michael Pleshakov <pleshakov@users.noreply.github.com>
Copy link
Contributor

@pleshakov pleshakov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@lucacome lucacome merged commit 2fcf6c1 into master Oct 9, 2020
@lucacome lucacome deleted the egress-mtls branch October 9, 2020 21:29
@lucacome lucacome self-assigned this Oct 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants