Validate TLS and CA secrets #1240
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pleshakov
added
the
enhancement
pleshakov
force-pushed
the
process-secrets-2
branch
from
a98ba53
to
5b081a3
Compare
lucacome
approved these changes
Nov 19, 2020
Dean-Coakley
approved these changes
Nov 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Previously, the contents of the TLS and CA secrets wasn't validated. As a result, NGINX could be configured to use an invalid TLS cert and/or key. In that case, NGINX would fail to reload. More over, NGINX would keep failing to reload until that secret was fixed/removed or a resource referencing that secret was removed.
This PR brings validation of the contents of secrets:
If a secret is invalid, NGINX will not be configured to use it.