Use chown(8) only once #1263
Merged
Use chown(8) only once #1263
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's possible to pass multiple files to chown utility, so run it only once to make changes.
|
Deploy request for nginx-kubernetes-ingress rejected. Rejected with commit 03e3e27 https://docs.netlify.com/configure-builds/environment-variables/#sensitive-variable-policy |
pleshakov
reviewed
Dec 4, 2020
| && chown -R nginx:0 /var/log/app_protect/ \ | ||
| && chown -R nginx:0 /opt/app_protect/ \ | ||
| && chown -R nginx:0 /var/log/nginx/ \ | ||
| /etc/nginx \ |
There was a problem hiding this comment.
the order of folders here is a bit different from the file build/appprotect/DockerfileWithAppProtectForPlus.
Could we use the same order for consistency?
There was a problem hiding this comment.
@pleshakov I've sorted that out cause in that order it has better readility, however I can revert that one.
Requsted by: pleshakov
pleshakov
approved these changes
Dec 4, 2020
lucacome
approved these changes
Dec 4, 2020
Requested by: lucacome
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's possible to pass multiple files to chown utility, so run it
only once to make changes.
Proposed changes
Describe the use case and detail of the change. If this PR addresses an issue on GitHub, make sure to include a link to that issue here in this description (not in the title of the PR).
Checklist
Before creating a PR, run through this checklist and mark each as complete.