Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use mkdir(1) just once. #1264

Merged
merged 2 commits into from
Dec 15, 2020
Merged

Use mkdir(1) just once. #1264

merged 2 commits into from
Dec 15, 2020

Conversation

osokin
Copy link
Contributor

@osokin osokin commented Dec 4, 2020

The mkdir(1) utility support multiple arguments, so it's possible
to use it once to create more than one directory.

Proposed changes

Describe the use case and detail of the change. If this PR addresses an issue on GitHub, make sure to include a link to that issue here in this description (not in the title of the PR).

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto master
  • I will ensure my PR is targeting the master branch and pulling from my branch from my own fork

The mkdir(1) utility support multiple arguments, so it's possible
to use it once to create more than one directory.
@netlify
Copy link

netlify bot commented Dec 4, 2020

Deploy request for nginx-kubernetes-ingress rejected.

Rejected with commit 7f143d7

https://docs.netlify.com/configure-builds/environment-variables/#sensitive-variable-policy

Copy link
Contributor

@Dean-Coakley Dean-Coakley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change looks good.

However, with this change these files will have mixed indentation. Can you change back to tabs?

Copy link
Contributor

@pleshakov pleshakov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@Dean-Coakley Dean-Coakley merged commit 92c0bde into nginxinc:master Dec 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants