Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support for App Protect UDS #1281

Merged
merged 1 commit into from
Dec 18, 2020
Merged

support for App Protect UDS #1281

merged 1 commit into from
Dec 18, 2020

Conversation

rafwegv
Copy link
Contributor

@rafwegv rafwegv commented Dec 14, 2020

Proposed changes

Introduce support for App Protect User Defined Signatures. Add new CRD and the required code to handle them.

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto master
  • I will ensure my PR is targeting the master branch and pulling from my branch from my own fork

@rafwegv rafwegv self-assigned this Dec 14, 2020
Copy link
Contributor

@Dean-Coakley Dean-Coakley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty good to me, left some comments about spelling errors and some suggestions for code cleanliness.

internal/k8s/app_protect_resources.go Outdated Show resolved Hide resolved
internal/k8s/app_protect_configuration.go Outdated Show resolved Hide resolved
internal/k8s/app_protect_configuration.go Outdated Show resolved Hide resolved
internal/k8s/app_protect_configuration.go Outdated Show resolved Hide resolved
Copy link
Contributor

@pleshakov pleshakov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@rafwegv rafwegv force-pushed the ap-user-defined-sigs-1 branch 2 times, most recently from db8c55b to b02d9d9 Compare December 18, 2020 07:52
@rafwegv rafwegv merged commit 18d1d1d into master Dec 18, 2020
@rafwegv rafwegv deleted the ap-user-defined-sigs-1 branch December 18, 2020 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants