Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for events #160

Merged
merged 1 commit into from
Jul 30, 2017
Merged

Add support for events #160

merged 1 commit into from
Jul 30, 2017

Conversation

pleshakov
Copy link
Contributor

  • Feature: The Ingress controller now emits events when generating or updating configuration for Ingress resources, either when an Ingress resource is added or updated or the ConfigMap with NGINX configuration is added or updated. The Ingress controller emits events for Ingress resources and the ConfigMap resource. If the configuration was not successfully applied (for example, NGINX failed to validate it), the controller emits a warning event with a description of the error.
  • Change: If the ConfigMap is added/updated, the Ingress controller first updates the configurations files for all Ingress resources and only then reloads NGINX. Before, the controller reloaded NGINX after updating the configuration of every Ingress resource.
  • Change: NGINX Plus upstream servers are now stored in the corresponding NGINX configuration file, instead of a separate state file. The Ingress controller updates endpoints without reloading NGINX Plus, via the API, as it was before.
  • Bugfix: When endpoints are removed from a Service (for example, when scaling the number of pods to 0), the Ingress controller didn't remove endpoints from NGINX Plus.
  • Bugfix: When the Ingress controller removed the last upstream server in an upstream in NGINX Plus, it reported an error, when there was no error.

- Feature: The Ingress controller now emits events when generating or updating configuration for Ingress resources, either when an Ingress resource is added or updated or the ConfigMap with NGINX configuration is added or updated. The Ingress controller emits events for Ingress resources and the ConfigMap resource. If the configuration was not successfully applied (for example, NGINX failed to validate it), the controller emits a warning event with a description of the error.
- Change: If the ConfigMap is added/updated, the Ingress controller first updates the configurations files for all Ingress resources and only then reloads NGINX. Before, the controller reloaded NGINX after updating the configuration of every Ingress resource.
- Change:  NGINX Plus upstream servers are now stored in the corresponding NGINX configuration file, instead of a separate state file. The Ingress controller updates endpoints without reloading NGINX Plus, via the API, as it was before.
- Bugfix: When endpoints are removed from a Service (for example, when scaling the number of pods to 0), the Ingress controller didn't remove endpoints from NGINX Plus.
- Bugfix: When the Ingress controller removed the last upstream server in an upstream in NGINX Plus, it reported an error, when there was no error.
@pleshakov pleshakov merged commit 7eaa2f1 into master Jul 30, 2017
@pleshakov pleshakov deleted the add-events branch July 30, 2017 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant