Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use edge version in manifests and Helm chart #347

Merged
merged 1 commit into from
Aug 24, 2018
Merged

Use edge version in manifests and Helm chart #347

merged 1 commit into from
Aug 24, 2018

Conversation

pleshakov
Copy link
Contributor

Proposed changes

  • Installation manifests and the helm chart use the edge version
  • Release commits will use the release version in the manifests and the helm chart

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto master
  • I will ensure my PR is targeting the master branch and pulling from my branch from my own fork

@pleshakov pleshakov added the enhancement Pull requests for new features/feature enhancements label Aug 22, 2018
Dean-Coakley
Dean-Coakley approved these changes Aug 22, 2018
View reviewed changes
Copy link
Contributor

@Dean-Coakley Dean-Coakley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. Please remove that trailing space on VERSION in the Makefile before merging

@pleshakov pleshakov merged commit 7366989 into master Aug 24, 2018
@pleshakov pleshakov deleted the use-edge-images branch August 24, 2018 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Dean-Coakley Dean-Coakley Dean-Coakley approved these changes

@peterkellydev peterkellydev peterkellydev approved these changes

Assignees
No one assigned
Labels
enhancement Pull requests for new features/feature enhancements
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pleshakov @peterkellydev @Dean-Coakley