Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve parsing nginx.org/rewrites annotation #389

Merged
merged 1 commit into from
Oct 5, 2018
Merged

Improve parsing nginx.org/rewrites annotation #389

merged 1 commit into from
Oct 5, 2018

Conversation

pleshakov
Copy link
Contributor

@pleshakov pleshakov commented Oct 4, 2018 •
edited
Loading

Proposed changes

Handle leading and trailing whitespace when parsing rewrites
for a service.

Based on #388

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto master
  • I will ensure my PR is targeting the master branch and pulling from my branch from my own fork

@pleshakov
Improve parsing nginx.org/rewrites annotation
78e3e44 
Handle leading and trailing whitespace when parsing rewrites
for a service.
@pleshakov pleshakov added the enhancement Pull requests for new features/feature enhancements label Oct 4, 2018
@pleshakov pleshakov mentioned this pull request Oct 4, 2018
Closed
Dean-Coakley
Dean-Coakley approved these changes Oct 5, 2018
View reviewed changes
Copy link
Contributor

@Dean-Coakley Dean-Coakley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@pleshakov pleshakov merged commit 1569843 into master Oct 5, 2018
@pleshakov pleshakov deleted the trim-whitespace-in-rewrite-annotation branch October 5, 2018 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Dean-Coakley Dean-Coakley Dean-Coakley approved these changes

@isaachawley isaachawley isaachawley approved these changes

Assignees
No one assigned
Labels
enhancement Pull requests for new features/feature enhancements
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pleshakov @isaachawley @Dean-Coakley