Refactor Helm Chart templates #393
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dean-Coakley
added
the
enhancement
Dean-Coakley
force-pushed
the
refactor-helm-chart
branch
from
5a495b5
to
80506e1
Compare
pleshakov
suggested changes
Oct 11, 2018
isaachawley
approved these changes
Oct 15, 2018
pleshakov
approved these changes
Oct 15, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Helm Chart deployment/daemonset templates had many unnecessary if statements. This PR optimises for cleanliness of deployment templates, at a minor expense of slightly messier deployment templates.
Tested with:
Checklist
Before creating a PR, run through this checklist and mark each as complete.