Improve secret handling #399
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pleshakov
added
enhancement
- Simplify the secret handling logic. - Change the secret handling logic. See below. Changes: 1. An Ingress includes TLS termination, but the referenced TLS Secret is missing in Kubernetes/invalid or goes missing/ becomes invalid. An Ingress can be a regular Ingress or a mergeable Master. Before: the Ingress resource was rejected. Now: the Ingress resource is not rejected. Instead, the generated config for that Ingress resource now includes the ssl_ciphers directive set to "NULL", which makes NGINX break any attempt to establish a TLS connection with the corresponding Ingress host. 2. An Ingress includes JWT auth, but the referenced JWK is missing in Kubernetes/invalid or goes missing/becomes invalid. An Ingress can be a regular Ingress, a mergeable Master or a mergeable Minion. Before: the Ingress resource was rejected. Now. the Ingress resource is not rejected. However, the generated config for that Ingress still references the JWK on the file system, which does not exist. This makes NGINX Plus return a 500 response for a request to the corresponding Ingress host (or the path of the host for mergeable minions).
pleshakov
force-pushed
the
refactor-secrets
branch
from
e94815c
to
7596444
Compare
| // JWTKey is the key of the data field of a Secret where the JWK must be stored. | ||
| const JWTKey = "jwk" | ||
| // JWTKeyKey is the key of the data field of a Secret where the JWK must be stored. | ||
| const JWTKeyKey = "jwk" |
There was a problem hiding this comment.
KeyKey!
Suggested change
| const JWTKeyKey = "jwk" | |
| const JWTKey = "jwk" |
peterkellydev
approved these changes
Oct 18, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Changes:
TLS Secret is missing in Kubernetes/invalid or goes missing/
becomes invalid. An Ingress can be a regular Ingress or a
mergeable Master.
Before: the Ingress resource was rejected.
Now: the Ingress resource is not rejected. Instead, the generated
config for that Ingress resource now includes the ssl_ciphers
directive set to "NULL", which makes NGINX break any attempt to
establish a TLS connection with the corresponding Ingress host.
missing in Kubernetes/invalid or goes missing/becomes invalid.
An Ingress can be a regular Ingress, a mergeable Master or
a mergeable Minion.
Before: the Ingress resource was rejected.
Now. the Ingress resource is not rejected. However, the generated
config for that Ingress still references the JWK on the file system,
which does not exist. This makes NGINX Plus return a 500 response
for a request to the corresponding Ingress host (or the path of the
host for mergeable minions).
Checklist
Before creating a PR, run through this checklist and mark each as complete.