Simplify values files for Helm Chart #420
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dean-Coakley
added
the
enhancement
isaachawley
approved these changes
Nov 6, 2018
Dean-Coakley
force-pushed
the
simplify-helm-values
branch
from
03b2e09
to
c909034
Compare
Dean-Coakley
changed the title
values-plus.yaml from Helm Chart
Dean-Coakley
force-pushed
the
simplify-helm-values
branch
from
c909034
to
3aab3cf
Compare
pleshakov
approved these changes
Nov 9, 2018
Only include values that override defaults in values.yaml
Dean-Coakley
force-pushed
the
simplify-helm-values
branch
from
3aab3cf
to
59592be
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
values-plus.yamlandvalues-icp.yamlshould only include values that it overrides invalues.yaml.Checklist
Before creating a PR, run through this checklist and mark each as complete.