Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add custom NodePort to helm controller-service. #477

Closed
wants to merge 4 commits into from
Closed

Add custom NodePort to helm controller-service. #477

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
60a7019
Add custom NodePort to helm controller-service.
sombralibre Jan 11, 2019
87520aa
add default NodePort parameters to values.yaml.
sombralibre Jan 14, 2019
6b5f2b8
Set Chart version to 0.3.2
sombralibre Jan 14, 2019
4b31232
Add blank line before EOF
sombralibre Jan 14, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion deployments/helm-chart/Chart.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
name: nginx-ingress
version: 0.3.1
version: 0.3.2
appVersion: edge
description: NGINX Ingress Controller
sources:
Expand Down
2 changes: 2 additions & 0 deletions deployments/helm-chart/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,6 +81,8 @@ Parameter | Description | Default
`controller.service.loadBalancerIP` | The static IP address for the load balancer. Requires `controller.service.type` set to `LoadBalancer`. The cloud provider must support this feature. | None
`controller.service.loadBalancerSourceRanges` | The IP ranges (CIDR) that are allowed to access the load balancer. Requires `controller.service.type` set to `LoadBalancer`. The cloud provider must support this feature. | []
`controller.service.externalIPs` | The list of external IPs for the Ingress controller service. | []
`controller.service.NodePort.Http` | Custom NodePort number for http. Requires `controller.service.type` set to `NodePort`. | None
sombralibre marked this conversation as resolved.
Show resolved Hide resolved
`controller.service.NodePort.Https` | Custom NodePort number for https. Requires `controller.service.type` set to `NodePort`. | None
`controller.serviceAccount.name` | The name of the service account of the Ingress controller pods. Used for RBAC. | nginx-ingress
`controller.serviceAccount.imagePullSecrets` | The names of the secrets containing docker registry credentials. | []
`controller.ingressClass` | A class of the Ingress controller. The Ingress controller only processes Ingress resources that belong to its class - i.e. have the annotation `"kubernetes.io/ingress.class"` equal to the class. Additionally, the Ingress controller processes Ingress resources that do not have that annotation which can be disabled by setting the "-use-ingress-class-only" flag. | nginx
Expand Down
10 changes: 10 additions & 0 deletions deployments/helm-chart/templates/controller-service.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,10 +33,20 @@ spec:
targetPort: 80
protocol: TCP
name: http
{{- if (eq .Values.controller.service.type "NodePort") }}
{{- if .Values.controller.service.NodePort.Http }}
nodePort: {{ .Values.controller.service.NodePort.Http }}
{{- end}}
{{- end}}
- port: 443
targetPort: 443
protocol: TCP
name: https
{{- if (eq .Values.controller.service.type "NodePort") }}
{{- if .Values.controller.service.NodePort.Https }}
nodePort: {{ .Values.controller.service.NodePort.Https }}
{{- end}}
{{- end}}
selector:
app: {{ .Values.controller.name | trunc 63 }}
{{- if .Values.controller.service.externalIPs }}
Expand Down
3 changes: 3 additions & 0 deletions deployments/helm-chart/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,9 @@ controller:
loadBalancerIP: ""
externalIPs: []
loadBalancerSourceRanges: []
NodePort:
Http: 32080
Https: 32443
serviceAccount:
name: nginx-ingress
imagePullSecrets: []
Expand Down