Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove ingress controller binary #484

Merged
merged 1 commit into from
Jan 31, 2019
Merged

Remove ingress controller binary #484

merged 1 commit into from
Jan 31, 2019

Conversation

Dean-Coakley
Copy link
Contributor

Proposed changes

nginx-controller binary was mistakenly added in #481
This PR removes the binary again

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have checked that all unit tests pass after adding my changes
  • I have rebased my branch onto master
  • I will ensure my PR is targeting the master branch and pulling from my branch from my own fork

@Dean-Coakley
Remove ingress controller binary
5d72a36 
nginx-controller binary was mistakenly added in #481
This PR removes the binary again
@Dean-Coakley Dean-Coakley added the bug An issue reporting a potential bug label Jan 31, 2019
@Dean-Coakley Dean-Coakley self-assigned this Jan 31, 2019
@Dean-Coakley Dean-Coakley merged commit f65e823 into master Jan 31, 2019
@Dean-Coakley Dean-Coakley deleted the rm-ic-binary branch January 31, 2019 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Rulox Rulox Rulox approved these changes

@pleshakov pleshakov Awaiting requested review from pleshakov

Assignees

@Dean-Coakley Dean-Coakley

Labels
bug An issue reporting a potential bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Dean-Coakley @Rulox