-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Telemetry Job #4896
Telemetry Job #4896
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #4896 +/- ##
==========================================
- Coverage 52.32% 52.29% -0.03%
==========================================
Files 61 62 +1
Lines 17502 17589 +87
==========================================
+ Hits 9158 9199 +41
- Misses 8015 8057 +42
- Partials 329 333 +4 ☔ View full report in Codecov by Sentry. |
Should this be mentioned somewhere in user-facing documentation? |
There will be documentation added as part of the overall implementation. |
@jjngx maybe we can implement a something like https://github.com/nginxinc/nginx-gateway-fabric/blob/9f4248e0d629f7953fde17f4f03bd95034306f7f/internal/mode/static/telemetry/telemetryfakes/fake_exporter.go for completeness in unit testing |
Reportign param value 1 minute is set now for testing and demo purpose. It will be removed in v3.5
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need consensus on how the telemetry job time period is handled - as string (that comes at the moment from flags) or as time.Duration
. If the latter, then unit tests would need to be updated.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍🏻
Proposed changes
This PR adds the base telemetry job that will be responsible for collecting telemetry data for each deployment of the Ingress Controller.
The current implementation of the Job writes collected, fake data to a dummy exporter.
Tasks to gather and report specific telemetry data points are outlined here: #4877
Tests
enable-telemetry-reporting
flag is set tofalse
enable-telemetry-reporting
it set tofalse
in Helm valuesChecklist
Before creating a PR, run through this checklist and mark each as complete.