Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add ingress rate-limit automation tests #4919

Merged
merged 5 commits into from
Jan 15, 2024
Merged

add ingress rate-limit automation tests #4919

merged 5 commits into from
Jan 15, 2024

Conversation

vepatel
Copy link
Contributor

@vepatel vepatel commented Jan 15, 2024 •
edited
Loading

Proposed changes

  • add ingress rate-limit automation tests
suite/test_rl_ingress.py::TestRateLimitIngress::test_ingress_rate_limit[standard] PASSED [ 64%]
suite/test_rl_ingress.py::TestRateLimitIngress::test_ingress_rate_limit[mergeable] PASSED [ 66%]

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@vepatel vepatel requested a review from a team as a code owner January 15, 2024 12:37
@github-actions github-actions bot added the tests Pull requests that update tests label Jan 15, 2024
@vepatel vepatel linked an issue Jan 15, 2024 that may be closed by this pull request
add example and automation test for "Support rate-limiting for ingress-resources" #4671
Closed
@vepatel vepatel merged commit 0d51baa into main Jan 15, 2024
76 checks passed
@vepatel vepatel deleted the tests/ingress-rl-annotation branch January 15, 2024 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jjngx jjngx jjngx approved these changes

@j1m-ryan j1m-ryan j1m-ryan approved these changes

@oseoin oseoin oseoin approved these changes

@haywoodsh haywoodsh Awaiting requested review from haywoodsh

Assignees
No one assigned
Labels
tests Pull requests that update tests
Projects
NGINX Ingress Controller
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

add example and automation test for "Support rate-limiting for ingress-resources"
4 participants
@vepatel @oseoin @j1m-ryan @jjngx