-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix minor documentation issues based on drift and feedback #5011
Fix minor documentation issues based on drift and feedback #5011
Conversation
This commit re-adds some documentation changes from late last year that were lost during some major refactoring. It also addresses some feedback submitted through the form that was missed during the interim period since as a result of some automation disconnecting, which meant the primary place the feedback is viewed received no updates.
👷 Deploy request for nginx-kubernetes-ingress pending review.Visit the deploys page to approve it
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5011 +/- ##
=======================================
Coverage 52.32% 52.32%
=======================================
Files 61 61
Lines 17502 17502
=======================================
Hits 9158 9158
Misses 8015 8015
Partials 329 329 ☔ View full report in Codecov by Sentry. |
docs/content/installation/running-multiple-ingress-controllers.md
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pending @j1m-ryan's comment resolution.
Co-authored-by: Jim Ryan <j.ryan@f5.com> Signed-off-by: Alan Dooley <github@adubhlaoi.ch>
Proposed changes
This pull request re-adds some documentation changes from late last year that were lost during some major refactoring.
It also addresses some feedback submitted through the form that was missed during the interim period as a result of some automation disconnecting, which meant the primary place the feedback is viewed received no updates.
Checklist
Before creating a PR, run through this checklist and mark each as complete.