Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added few tips for TCP/UDP Load Balancing #5117

Merged
merged 6 commits into from
Feb 26, 2024

Conversation

ssrahul96
Copy link
Contributor

@ssrahul96 ssrahul96 commented Feb 19, 2024

Proposed changes

Describe the use case and detail of the change. If this PR addresses an issue on GitHub, make sure to include a link to
that issue here in this description (not in the title of the PR).

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@ssrahul96 ssrahul96 requested a review from a team as a code owner February 19, 2024 04:04
Copy link

netlify bot commented Feb 19, 2024

👷 Deploy request for nginx-kubernetes-ingress pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit 86ac4f5

@github-actions github-actions bot added the documentation Pull requests/issues for documentation label Feb 19, 2024
Copy link
Member

@j1m-ryan j1m-ryan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, pending Docs Team approval

examples/custom-resources/basic-tcp-udp/README.md Outdated Show resolved Hide resolved
examples/custom-resources/basic-tcp-udp/README.md Outdated Show resolved Hide resolved
@j1m-ryan
Copy link
Member

@ADubhlaoich

Copy link
Contributor

@ADubhlaoich ADubhlaoich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@j1m-ryan j1m-ryan enabled auto-merge (squash) February 21, 2024 11:58
@j1m-ryan j1m-ryan merged commit 2afee89 into nginxinc:main Feb 26, 2024
51 checks passed
@ssrahul96 ssrahul96 deleted the trasnport-server-docs branch June 20, 2024 02:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Pull requests/issues for documentation
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants