Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

check pod status before getting logs #5165

Merged
merged 2 commits into from
Feb 26, 2024
Merged

Conversation

vepatel
Copy link
Contributor

@vepatel vepatel commented Feb 26, 2024

Proposed changes

  • check external-dns pod status before getting logs
Step 2: Verify external-dns picked up the record
Start waiting for all pods in a namespace to be Ready
Pod external-dns-647d5b4f6f-q9d5k has image k8s.gcr.io/external-dns/external-dns:v0.12.2
There are pods that are not Ready. Wait for 1 sec...
Pod external-dns-647d5b4f6f-q9d5k has image k8s.gcr.io/external-dns/external-dns:v0.12.2
All pods are Ready
========= 2 passed, 503 deselected, 47 warnings in 177.70s (0:02:57) ========

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@vepatel vepatel requested a review from a team as a code owner February 26, 2024 14:16
@github-actions github-actions bot added the tests Pull requests that update tests label Feb 26, 2024
@vepatel vepatel linked an issue Feb 26, 2024 that may be closed by this pull request
@vepatel vepatel merged commit 30f95c0 into main Feb 26, 2024
78 checks passed
@vepatel vepatel deleted the tests/fix-wait-externaldns-pods branch February 26, 2024 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tests Pull requests that update tests
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Investigate intermittent ExternalDNS test failure
5 participants