Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Weight changes Dynamic Reload #5212

Merged
merged 41 commits into from
Mar 19, 2024
Merged

Weight changes Dynamic Reload #5212

merged 41 commits into from
Mar 19, 2024

Conversation

j1m-ryan
Copy link
Member

@j1m-ryan j1m-ryan commented Mar 7, 2024 •
edited
Loading

Proposed changes

Describe the use case and detail of the change. If this PR addresses an issue on GitHub, make sure to include a link to
that issue here in this description (not in the title of the PR).

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@j1m-ryan j1m-ryan requested review from a team as code owners March 7, 2024 13:41
@github-actions github-actions bot added dependencies Pull requests that update a dependency file documentation Pull requests/issues for documentation helm_chart Pull requests that update the Helm Chart labels Mar 7, 2024
@j1m-ryan j1m-ryan marked this pull request as draft March 7, 2024 13:42
@github-actions github-actions bot added the tests Pull requests that update tests label Mar 8, 2024
ADubhlaoich
ADubhlaoich reviewed Mar 12, 2024
View reviewed changes
Copy link
Contributor

@ADubhlaoich ADubhlaoich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Singular doc change LGTM, ping if there's more when the PR gets close to completion.

@j1m-ryan j1m-ryan marked this pull request as ready for review March 13, 2024 15:38
@j1m-ryan j1m-ryan changed the title [Draft] Weight changes without reload Weight changes without reload Mar 13, 2024
oseoin
oseoin reviewed Mar 13, 2024
View reviewed changes
build/Dockerfile Outdated Show resolved Hide resolved
jjngx
jjngx approved these changes Mar 15, 2024
View reviewed changes
Copy link
Contributor

@jjngx jjngx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@j1m-ryan j1m-ryan force-pushed the weight-changes-without-reload branch from e7688a3 to 526f4a8 Compare March 15, 2024 17:48
oseoin
oseoin reviewed Mar 19, 2024
View reviewed changes
cmd/nginx-ingress/flags.go Outdated Show resolved Hide resolved
@j1m-ryan j1m-ryan changed the title Weight changes without reload Weight changes Dynamic Reload Mar 19, 2024
@j1m-ryan j1m-ryan enabled auto-merge (squash) March 19, 2024 14:21
@j1m-ryan j1m-ryan merged commit 7ae7399 into main Mar 19, 2024
53 checks passed
@j1m-ryan j1m-ryan deleted the weight-changes-without-reload branch March 19, 2024 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oseoin oseoin oseoin approved these changes

@ADubhlaoich ADubhlaoich ADubhlaoich left review comments

@shaun-nx shaun-nx shaun-nx approved these changes

@jjngx jjngx jjngx approved these changes

Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file documentation Pull requests/issues for documentation helm_chart Pull requests that update the Helm Chart tests Pull requests that update tests
Projects
NGINX Ingress Controller
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@j1m-ryan @ADubhlaoich @oseoin @jjngx @shaun-nx