Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

helm: add knob to control cluster level rbac rendering #5229

Merged
merged 4 commits into from
Jun 6, 2024
Merged

helm: add knob to control cluster level rbac rendering #5229

merged 4 commits into from
Jun 6, 2024
+7 −1

Conversation

hafe
Copy link
Contributor

@hafe hafe commented Mar 10, 2024 •
edited
Loading

Closes #5228

Proposed changes

Describe the use case and detail of the change. If this PR addresses an issue on GitHub, make sure to include a link to
that issue here in this description (not in the title of the PR).

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@hafe hafe requested a review from a team as a code owner March 10, 2024 20:16
@netlify Netlify
Copy link

netlify bot commented Mar 10, 2024 •
edited
Loading

👷 Deploy request for nginx-kubernetes-ingress pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit 701f1f6

@github-actions github-actions bot added documentation Pull requests/issues for documentation helm_chart Pull requests that update the Helm Chart labels Mar 10, 2024
@hafe hafe force-pushed the chart-rbac-knob branch 3 times, most recently from 7f0e444 to a0860ac Compare May 21, 2024 18:20
@hafe hafe requested a review from a team as a code owner May 21, 2024 18:20
ADubhlaoich
ADubhlaoich approved these changes Jun 4, 2024
View reviewed changes
Copy link
Contributor

@ADubhlaoich ADubhlaoich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM docs-wise

@vepatel vepatel merged commit 0d8fd72 into nginxinc:main Jun 6, 2024
108 of 126 checks passed
ssrahul96 pushed a commit to ssrahul96/kubernetes-ingress that referenced this pull request Jun 20, 2024
@hafe @ssrahul96
helm: add knob to control cluster level rbac rendering (nginxinc#5229)
ccd1814
This was referenced Jul 1, 2024
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vepatel vepatel vepatel approved these changes

@shaun-nx shaun-nx shaun-nx approved these changes

@ADubhlaoich ADubhlaoich ADubhlaoich approved these changes

Assignees
No one assigned
Labels
documentation Pull requests/issues for documentation helm_chart Pull requests that update the Helm Chart
Projects
NGINX Ingress Controller
Status: Done 🚀
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow helm chart to support external cluster level RBAC
4 participants
@hafe @ADubhlaoich @vepatel @shaun-nx