Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the before NGINX Ingress Controller in some cases #5274

Merged
merged 3 commits into from
Mar 20, 2024

Conversation

j1m-ryan
Copy link
Member

Docs update that removes The before NGINX Ingress Controller in some cases

When it's followed by a noun I have left it alone
The NGINX Ingress Controller (pod|service|repo|deployment) is unchanged

Most changed instances are in the form The NGINX Ingress Controller <verb>

Proposed changes

Describe the use case and detail of the change. If this PR addresses an issue on GitHub, make sure to include a link to
that issue here in this description (not in the title of the PR).

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@j1m-ryan j1m-ryan requested review from a team as code owners March 20, 2024 09:40
@github-actions github-actions bot added documentation Pull requests/issues for documentation helm_chart Pull requests that update the Helm Chart labels Mar 20, 2024
Copy link
Contributor

@ADubhlaoich ADubhlaoich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A+, no notes.

@j1m-ryan j1m-ryan enabled auto-merge (squash) March 20, 2024 15:08
@j1m-ryan j1m-ryan merged commit 0aeb4a7 into main Mar 20, 2024
77 checks passed
@j1m-ryan j1m-ryan deleted the docs/remove-the-before-nic branch March 20, 2024 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Pull requests/issues for documentation helm_chart Pull requests that update the Helm Chart
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants