Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix false-positive code scanning issue #5365

Merged
merged 1 commit into from
Apr 9, 2024
Merged

Fix false-positive code scanning issue #5365

merged 1 commit into from
Apr 9, 2024

Conversation

jjngx
Copy link
Contributor

@jjngx jjngx commented Apr 9, 2024

Proposed changes

This PR, if merged, will fix false-positive code scanning issues. The var names with prefixes "secret" are recognised by the scanner as secrets (passed to logs).

scanning issues:

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@jjngx jjngx requested a review from a team as a code owner April 9, 2024 10:57
@github-actions github-actions bot added the chore Pull requests for routine tasks label Apr 9, 2024
@jjngx jjngx merged commit 432826f into main Apr 9, 2024
77 checks passed
@jjngx jjngx deleted the chore/clear-text-log branch April 9, 2024 11:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Pull requests for routine tasks
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants