Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Republish helm chart workflow #5370

Merged
merged 9 commits into from
Apr 15, 2024
Merged

Republish helm chart workflow #5370

merged 9 commits into from
Apr 15, 2024

Conversation

pdabelf5
Copy link
Collaborator

@pdabelf5 pdabelf5 commented Apr 10, 2024 •
edited
Loading

Proposed changes

Allow helm chart to be republished from a branch

### Examples

inputs.branch: <branch_name> # e.g. release-3.5

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@pdabelf5 pdabelf5 requested review from a team as code owners April 10, 2024 15:18
@github-actions github-actions bot added documentation Pull requests/issues for documentation helm_chart Pull requests that update the Helm Chart labels Apr 10, 2024
@github-actions github-actions bot removed the helm_chart Pull requests that update the Helm Chart label Apr 10, 2024
shaun-nx
shaun-nx approved these changes Apr 12, 2024
View reviewed changes
Copy link
Contributor

@shaun-nx shaun-nx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏

@github-actions github-actions bot added the tests Pull requests that update tests label Apr 12, 2024
@pdabelf5 pdabelf5 removed the tests Pull requests that update tests label Apr 15, 2024
@github-actions github-actions bot added the chore Pull requests for routine tasks label Apr 15, 2024
@pdabelf5 pdabelf5 merged commit 39bf194 into main Apr 15, 2024
80 checks passed
@pdabelf5 pdabelf5 deleted the republish-helm branch April 15, 2024 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shaun-nx shaun-nx shaun-nx approved these changes

@jjngx jjngx jjngx approved these changes

Assignees
No one assigned
Labels
chore Pull requests for routine tasks documentation Pull requests/issues for documentation
Projects
NGINX Ingress Controller
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@pdabelf5 @jjngx @shaun-nx @nginx-bot