Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Ingress Classes to Telemetry data #5418

Merged
merged 3 commits into from
Apr 18, 2024
Merged

Conversation

jjngx
Copy link
Contributor

@jjngx jjngx commented Apr 17, 2024

Proposed changes

Add Ingress Classes to telemetry data payload.

log:

I0417 14:02:48.994112       1 collector.go:128] Telemetry data collected: {Data:{ProjectName:NIC ProjectVersion:3.6.0-SNAPSHOT ProjectArchitecture:amd64 ClusterID:41611749-00ad-4f54-8e95-ea6400abe4bc ClusterVersion:v1.29.2 ClusterPlatform:kind InstallationID:6fb6c436-3086-48be-a650-b9a4b25b510a ClusterNodeCount:1} NICResourceCounts:{VirtualServers:0 VirtualServerRoutes:0 TransportServers:0 Replicas:1 Secrets:2 Ingresses:1 IngressClasses:1}}

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@jjngx jjngx requested review from a team as code owners April 17, 2024 14:49
@github-actions github-actions bot added enhancement Pull requests for new features/feature enhancements documentation Pull requests/issues for documentation go Pull requests that update Go code helm_chart Pull requests that update the Helm Chart labels Apr 17, 2024
@jjngx jjngx linked an issue Apr 17, 2024 that may be closed by this pull request
@jjngx jjngx added this to the v3.6.0 milestone Apr 17, 2024
Copy link
Contributor

@ADubhlaoich ADubhlaoich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM docs-wise!

@jjngx jjngx merged commit 72f146a into main Apr 18, 2024
81 checks passed
@jjngx jjngx deleted the feat/telemetry-ingress-class branch April 18, 2024 08:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Pull requests/issues for documentation enhancement Pull requests for new features/feature enhancements go Pull requests that update Go code helm_chart Pull requests that update the Helm Chart
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Collect count of IngressClasses
4 participants