Update helm-chart rbac to have minimum required privileges #542
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dean-Coakley
force-pushed
the
fix/rbac-helm-chart
branch
from
b867d10
to
2679efd
Compare
When the "controller.reportIngressStatus.enableLeaderElection" is false, the RBAC must not allow the IC to create/update the ConfigMaps.
Dean-Coakley
force-pushed
the
fix/rbac-helm-chart
branch
from
2679efd
to
da9d5af
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
The leader election used in the status reporting feature requires the IC to create/update a Configmap. Thus, RBAC must allow that. However, when the feature is disabled, the RBAC must now allow create/update on the Configmap.
When the
controller.reportIngressStatus.enableLeaderElectionis false, the RBAC must not allow the IC to create/update the ConfigMaps.Checklist
Before creating a PR, run through this checklist and mark each as complete.