Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated Go code #5559

Merged
merged 14 commits into from
May 20, 2024
Merged

Remove deprecated Go code #5559

merged 14 commits into from
May 20, 2024

Conversation

jjngx
Copy link
Contributor

@jjngx jjngx commented May 16, 2024

Proposed changes

This PR removes deprecated code.

References:

  • staticcheck:
➜  kubernetes-ingress git:(test/staticcheck) ✗ staticcheck ./internal/certmanager/test_files/*.go
internal/certmanager/test_files/util.go:26:2: rand.Seed has been deprecated since Go 1.20 and an alternative has been available since Go 1.0: As of Go 1.20 there is no reason to call Seed with a random value. Programs that call Seed with a known value to get a specific sequence of results should use New(NewSource(seed)) to obtain a local random generator.  (SA1019)

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@jjngx jjngx requested a review from a team as a code owner May 16, 2024 08:38
@github-actions github-actions bot added the go Pull requests that update Go code label May 16, 2024
@jjngx jjngx merged commit 58deae3 into main May 20, 2024
78 checks passed
@jjngx jjngx deleted the test/staticcheck branch May 20, 2024 09:10
ssrahul96 pushed a commit to ssrahul96/kubernetes-ingress that referenced this pull request Jun 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
go Pull requests that update Go code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants