Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix error msg to comply with a Go linter #5582

Merged
merged 4 commits into from
May 20, 2024
Merged

Conversation

jjngx
Copy link
Contributor

@jjngx jjngx commented May 20, 2024

Proposed changes

This PR makes error massages in the secret pkg comply with the linter:

Before:

➜  kubernetes-ingress git:(main) staticcheck ./...
...
internal/k8s/secrets/validation.go:81:10: error strings should not be capitalized (ST1005)
internal/k8s/secrets/validation.go:84:10: error strings should not be capitalized (ST1005)
internal/k8s/secrets/validation.go:115:10: error strings should not be capitalized (ST1005)
internal/k8s/secrets/validation.go:119:10: error strings should not be capitalized (ST1005)
internal/k8s/secrets/validation.go:152:9: error strings should not be capitalized (ST1005)

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@jjngx jjngx requested a review from a team as a code owner May 20, 2024 09:43
@github-actions github-actions bot added the go Pull requests that update Go code label May 20, 2024
@jjngx jjngx merged commit 202b3d6 into main May 20, 2024
78 checks passed
@jjngx jjngx deleted the test/fix-staticcheck-error-mgs branch May 20, 2024 11:57
ssrahul96 pushed a commit to ssrahul96/kubernetes-ingress that referenced this pull request Jun 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
go Pull requests that update Go code
Projects
Status: Done 🚀
Development

Successfully merging this pull request may close these issues.

3 participants