-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Installation Flags to Telemetry #5586
Conversation
+ remove non-working tests
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM docs-wise
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM docs-wise.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice job Alex 😄
Co-authored-by: Shaun <s.odonovan@f5.com> Signed-off-by: AlexFenlon <a.fenlon@f5.com>
Proposed changes
This adds a list of the arguments/flags set in the deployment to Telemetry.
I have added go tests to test this functionality as well as done several manual tests to verify this change:
I created a deployment using manifests and deployed this file:
the changes I made to the deployment are below:
the snippet of the telemetry log for this deployment is :
Changing around these flags shows that this the deployment args look like:
the snippet of the telemetry log for this deployment is :
example using nginx-plus installing using helm:
the snippet of the telemetry log of a nginx plus deployment using helm:
Resolves: #5416
Checklist
Before creating a PR, run through this checklist and mark each as complete.