Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix test artifact name and test marker #5596

Merged
merged 2 commits into from
May 21, 2024
Merged

fix test artifact name and test marker #5596

merged 2 commits into from
May 21, 2024

Conversation

vepatel
Copy link
Contributor

@vepatel vepatel commented May 21, 2024 •
edited
Loading

Proposed changes

  • fix test artifact name and test marker

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@vepatel vepatel requested a review from a team as a code owner May 21, 2024 09:28
@vepatel vepatel requested review from oseoin, jjngx and pdabelf5 May 21, 2024 09:28
@github-actions github-actions bot added github_actions Pull requests that update Github_actions code chore Pull requests for routine tasks labels May 21, 2024
@vepatel vepatel enabled auto-merge (squash) May 21, 2024 09:46
@vepatel vepatel merged commit 2124431 into main May 21, 2024
54 checks passed
@vepatel vepatel deleted the chore/fix-test-artifacts branch May 21, 2024 10:19
@j1m-ryan j1m-ryan mentioned this pull request May 22, 2024
Closed
ssrahul96 pushed a commit to ssrahul96/kubernetes-ingress that referenced this pull request Jun 20, 2024
@vepatel @ssrahul96
fix test artifact name and test marker (nginxinc#5596)
b62d621
This was referenced Jul 1, 2024
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pdabelf5 pdabelf5 pdabelf5 approved these changes

@oseoin oseoin oseoin approved these changes

@jjngx jjngx Awaiting requested review from jjngx

Assignees
No one assigned
Labels
chore Pull requests for routine tasks github_actions Pull requests that update Github_actions code
Projects
NGINX Ingress Controller
Status: Done 🚀
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vepatel @oseoin @pdabelf5