Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fail smoke test job if we get a cache miss on fetching the binary #5672

Merged
merged 2 commits into from
May 31, 2024
Merged

fail smoke test job if we get a cache miss on fetching the binary #5672

merged 2 commits into from
May 31, 2024

Conversation

pdabelf5
Copy link
Collaborator

@pdabelf5 pdabelf5 commented May 31, 2024 •
edited
Loading

Proposed changes

Fail fast if we get a cache miss when fetching the binary from the github cache

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@pdabelf5 pdabelf5 requested a review from a team as a code owner May 31, 2024 09:51
@github-actions github-actions bot added github_actions Pull requests that update Github_actions code chore Pull requests for routine tasks labels May 31, 2024
@AlexFenlon AlexFenlon merged commit cd7ca7c into main May 31, 2024
78 checks passed
@AlexFenlon AlexFenlon deleted the smoke-test-fail branch May 31, 2024 10:47
ssrahul96 pushed a commit to ssrahul96/kubernetes-ingress that referenced this pull request Jun 20, 2024
@pdabelf5 @ssrahul96
fail smoke test job if we get a cache miss on fetching the binary (ng…
c862f81 
…inxinc#5672)
This was referenced Jul 1, 2024
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jjngx jjngx jjngx approved these changes

@AlexFenlon AlexFenlon AlexFenlon approved these changes

@vepatel vepatel vepatel approved these changes

Assignees
No one assigned
Labels
chore Pull requests for routine tasks github_actions Pull requests that update Github_actions code
Projects
NGINX Ingress Controller
Status: Done 🚀
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@pdabelf5 @vepatel @AlexFenlon @jjngx